Conversation
Contributor
HanXHX
commented
Mar 12, 2026
HanXHX
commented
- Add helpers in Makefile
- Setup CI for unit tests
- Global add tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a unit testing setup across core packages of the CLI, plus local/CI coverage reporting, to improve confidence in API/auth/crypto/config behavior.
Changes:
- Added unit tests for UI formatting, crypto (AGE), config/token persistence, OIDC auth flows, and API client endpoints.
- Added a
make test-coveragehelper and ignored generated coverage artifacts. - Updated CI to print a coverage summary from
coverage.out.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/ui/format_test.go |
Adds coverage for FormatSize human-readable byte formatting. |
internal/crypto/age_test.go |
Adds tests for hybrid AGE key parsing + encrypt/decrypt helpers and edge cases. |
internal/config/config_test.go |
Adds tests for viper defaults and token save/load/delete behavior and permissions. |
internal/auth/oidc_test.go |
Adds tests for OIDC device-flow helpers, refresh/revoke, and token source behavior. |
internal/api/client_test.go |
Adds tests for core HTTP client verbs, error handling, multipart upload, and UA transport. |
internal/api/login_test.go |
Adds tests for fetching OIDC config + discovery error cases. |
internal/api/transfer_test.go |
Adds tests for transfer listing/details/files and create/complete/enable/disable/chunk ops. |
internal/api/user_test.go |
Adds tests for user profile/quota and active key (including null) behavior. |
cmd/transfer.go |
Minor refactor in generateTransferPassphrase variable naming and whitespace cleanup. |
cmd/helpers_test.go |
Adds tests for CLI helpers (expiry formatting, passphrase generator, JWT offline detection). |
Makefile |
Adds test-coverage target (coverage.out/html generation + summary). |
.gitignore |
Ignores coverage.out and coverage.html. |
.github/workflows/_ci.yml |
Prints coverage summary after tests in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.